WI00737678---RemoveDragNodesBehavior #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heathermcx
requested changes
Jul 3, 2024
Comment on lines
13
to
18
| public record NodeMoveablePositions(Point position) | ||
| { | ||
| public Dictionary<NodeModel, DiagramPoint> ChildPositions { get; } = new(); | ||
| } | ||
|
|
||
| protected readonly Dictionary<NodeModel, NodeMoveablePositions> _initialPositions; |
There was a problem hiding this comment.
I think we have some misunderstanding from yesterday. We should not add ChildPositions in Blazor.Diagrams, I thought we will just make _initialPositions protected so that we can reuse it in our implementation. Is there a solution where we use _initialPositions with the type Dictionary<MovableModle, Point> from this base class in our implementation?
Suggested change
| public record NodeMoveablePositions(Point position) | |
| { | |
| public Dictionary<NodeModel, DiagramPoint> ChildPositions { get; } = new(); | |
| } | |
| protected readonly Dictionary<NodeModel, NodeMoveablePositions> _initialPositions; | |
| protected readonly Dictionary<MovableModle, Point> _initialPositions; |
Heathermcx
reviewed
Jul 5, 2024
| @@ -28,6 +27,8 @@ protected override void OnPointerDown(Model? model, PointerEventArgs e) | |||
| if (model is not MovableModel) | |||
| return; | |||
|
|
|||
| ResetPan(); | |||
There was a problem hiding this comment.
We can't add this to Blazor.Diagrams - this means that every time I try to drag a node, the diagram view is repositioned to 0,0 even if I have panned the diagram. This makes it really hard to drag the node and also changes the users view without them trying to change view.
Heathermcx
approved these changes
Jul 10, 2024
tripti-wani
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WI00737678---RemoveDragNodesBehaviorUpdates